Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(backend): Inboxのエラーをthrowせずreturnしている問題を修正 #15022

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

kakkokari-gtyih
Copy link
Contributor

What

Fixes a type confusion bug where exceptions are incorrectly returned instead of thrown. The calling code will attempt to process the Error as an Activity, causing it to fail with cryptic and confusing errors.

Why

Fix https://activitypub.software/TransFem-org/Sharkey/-/issues/796
エラーがエラーとしてログに残るようになる

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

warriordog and others added 4 commits November 22, 2024 09:54
(cherry picked from commit 8f42e8434eaebe3aba5d1980c57f49dd8ad0de91)
(cherry picked from commit cfc3ab4b045af0674122fa49176431860176358b)
@github-actions github-actions bot added the packages/backend Server side specific issue/PR label Nov 22, 2024
Copy link
Contributor

このPRによるapi.jsonの差分
差分はありません。
Get diff files from Workflow Page

Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 11.11111% with 8 lines in your changes missing coverage. Please review.

Project coverage is 39.86%. Comparing base (c1f19fa) to head (d7e7b9a).
Report is 6 commits behind head on develop.

Files with missing lines Patch % Lines
...ges/backend/src/core/activitypub/ApInboxService.ts 11.11% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #15022      +/-   ##
===========================================
- Coverage    39.98%   39.86%   -0.12%     
===========================================
  Files         1563     1563              
  Lines       197737   197741       +4     
  Branches      3644     3633      -11     
===========================================
- Hits         79056    78835     -221     
- Misses      118077   118299     +222     
- Partials       604      607       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@syuilo syuilo merged commit f25fc52 into misskey-dev:develop Nov 22, 2024
32 checks passed
@syuilo
Copy link
Member

syuilo commented Nov 22, 2024

🙏

@kakkokari-gtyih kakkokari-gtyih deleted the fix-be-type-0 branch November 22, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/backend Server side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants