Release 2.0 #181
Merged
Release 2.0 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not setting it will throw a user-friendly error. Since the image/image_family logic is dealt with in zone-specific config, this will _greatly_ simplify things. Provider-level configuration shouldn't have contained that information in the first place.
Adding tests for new behavior. Fixes mitchellh#137
|
Was testing this release locally and found a small issue: for some reason I can't specify the location of the GCE key using |
|
@zackangelo Thanks for catching this! Should be fixed now. |
This was referenced Mar 23, 2018
seanmalloy
reviewed
Mar 24, 2018
| @@ -88,7 +89,9 @@ Vagrant.configure("2") do |config| | |||
| google.google_project_id = "YOUR_GOOGLE_CLOUD_PROJECT_ID" | |||
| google.google_client_email = "YOUR_SERVICE_ACCOUNT_EMAIL_ADDRESS" | |||
| google.google_json_key_location = "/path/to/your/private-key.json" | |||
|
|
|||
|
|
|||
| google.image_family = 'ubuntu-1604-lts' | |||
There was a problem hiding this comment.
One suggestion ... it would be nice if the new image_family config option was also added to the Configuration section of the README.
There was a problem hiding this comment.
@seanmalloy Nicely spotted! Thanks!
Added.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, let's do this. @erjohnso PTAL
Tested #180 - looking good 👍
Since we're entering 2.0, will implement 2 additional breaking changes:
imageparameter will no longer default to an arbitrary one.Not setting it will throw a user-friendly error. Since the
image/image_family logic is dealt with in zone-specific config,
this will greatly simplify things.
Provider-level configuration shouldn't have contained that
information in the first place as it's executed multiple times
and will cause collisions if the zone parameter is set at runtime (like image family). Fixes [FR] Support image families #144
Upgrading to new standard
SyncedFoldersaction and removing old rsync code. This time it should be ok as I finally found a proper workaround - all test pass ^___^Fixes rsync__args not respected #158, Trigger rsync installation if not installed #152,
vagrant rsynccommand does not work #137, Rename rsync__excludes to rsync__exclude #109, "vagrant provision" fails with "host IP was given to the Vagrant core NFS helper" #94, Vagrant provision order #87Made some drive-by fixes as well: