cosmetic changes #175
cosmetic changes #175
Conversation
dschach
commented
Mar 20, 2025
•
dschach
commented
- Prettier updates
- Clean workflow files
- Remove unnecessary node modules
- Tests pass
- Appropriate changes to README are included in PR
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@mitchspano I know this is a lame PR, but my next one will involve an option to debug limits in an execution. |
|
This is a very large PR. Can we break it down into smaller changes? |
|
@mitchspano Done. This is now cosmetic plus an update to the workflow to use I can't tell if the documentation in |
...fault/objects/sObject_Trigger_Setting__mdt/fields/TriggerRecord_Class_Name__c.field-meta.xml
Outdated
Show resolved
Hide resolved
Docs are auto-generated. Those should be left alone. |
| @@ -29,6 +30,7 @@ jobs: | |||
| sf plugins install @salesforce/sfdx-scanner | |||
|
|
|||
| - name: Run SFDX Scanner - Report findings as comments | |||
| if: github.event_name == 'pull_request' | |||
There was a problem hiding this comment.
Is this necessary? The triggering event is always pull_request
| node-version: ">=14" | ||
| check-latest: true | ||
| node-version: "lts/*" | ||
| #cache: "npm" |
There was a problem hiding this comment.
Is this comment intentional? Please remove or uncomment.
| }, | ||
| { | ||
| "files": "*.trigger", | ||
| "options": { "printWidth": 200 } |
There was a problem hiding this comment.
Why is this different than the other print width specification
There was a problem hiding this comment.
When the width is less than 200, all the trigger contexts listed go one above each other on separate lines, making it unnecessarily harder (at least for me) to understand. However, since there are no triggers in this project, I can remove it.
| @@ -1,15 +1,81 @@ | |||
| { | |||
There was a problem hiding this comment.
What is the source of all of this customization in this file?
The standard config is available here. I see advantage in specifying apexInsertFinalNewline : false, but the rest of the stuff seems to be the project-specific configuration from another team's project.
