Functionality catalog #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merge main
geoffxy
reviewed
Oct 24, 2023
There was a problem hiding this comment.
Thanks @ferdiko! Can you look into the Session changes mentioned below? I think that we should avoid storing the session in QueryRep to avoid coupling them. QueryRep should just be a class that represents a query.
Changing that and the paths below should fix the tests as well.
|
Please also add back the script you used to extract the keywords for the geospatial queries (just commit it under |
geoffxy
approved these changes
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey Geoff, I "unit tested" the functionality catalog but it would be great if you could check if it breaks any of your things.