Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make connection initialization more robust #366

Merged
merged 4 commits into from
Nov 14, 2023
Merged

Make connection initialization more robust #366

merged 4 commits into from
Nov 14, 2023

Conversation

geoffxy
Copy link
Member

@geoffxy geoffxy commented Nov 13, 2023 •
edited
Loading

This should (hopefully) fix the analytical runner connection issue we have been seeing.

  • Adds more debug output and removes the verbose transient error output
  • Adds a connection retry when establishing a first connection to BRAD
  • Modifies our RPC API to send back connection errors; abort the experiment if this happens

Part of #296.

@geoffxy geoffxy added the bug Something isn't working label Nov 13, 2023
@geoffxy geoffxy self-assigned this Nov 13, 2023
@geoffxy geoffxy merged commit 59b55fd into main Nov 14, 2023
1 check passed
@geoffxy geoffxy deleted the gy-conn-debug branch November 14, 2023 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@geoffxy geoffxy

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@geoffxy