Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement the new benefit horizon #379

Merged
merged 11 commits into from
Nov 21, 2023
Merged

Implement the new benefit horizon #379

merged 11 commits into from
Nov 21, 2023

Conversation

geoffxy
Copy link
Member

@geoffxy geoffxy commented Nov 21, 2023

Resolves #372.

@geoffxy geoffxy self-assigned this Nov 21, 2023
@geoffxy
Copy link
Member Author

geoffxy commented Nov 21, 2023

This does not seem to affect the existing comparator. So it is safe to merge, but we should test this new benefit comparator a bit more before running an end-to-end experiment.

@geoffxy geoffxy merged commit 45e4dc4 into main Nov 21, 2023
@geoffxy geoffxy deleted the gy-benefit branch November 21, 2023 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for the "payoff" / "benefit" period in relation to transition time
1 participant