Add learned index (RadixSpline) Rust bindings #511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoffxy
approved these changes
May 17, 2024
There was a problem hiding this comment.
Looks good - thanks @xingalbert! Please take a look at and address the comments before squash merging.
Please also
- Add a newline to the end of each file - it looks like your editor was omitting them from each file
- Run
blackon the Python files intpch(pip3 install blackand thenblack path/to/file.py) before merging
geoffxy
force-pushed
the
learned-index
branch
from
1f9b1da to
3a29c59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add end to end tpch benchmarking code
add build script that compiles and links c++ radixspline library
add safe rust module for running radixspline
Note: may need to manually delete radixspline.o and libradixspline.a from sandbox/qe/RadixSplineLib to force recompilation when changes are made to the C++ radixspline code.