Fix formatted shared strings (regressio in 1.7.0)

mitigate-dev · Aug 28, 2017 · 0b8b11c · 0b8b11c
1 parent 5fe9b13
commit 0b8b11c
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/lib/saxlsx/shared_string_collection_parser.rb b/lib/saxlsx/shared_string_collection_parser.rb
@@ -16,7 +16,7 @@ def initialize(&block)
     end
 
     def start_element(name)
-      @current_string = '' if name == :si
+      @current_string = String.new if name == :si
     end
 
     def end_element(name)
@@ -27,7 +27,7 @@ def end_element(name)
     end
 
     def text(value)
-      @current_string = CGI.unescapeHTML(value) if @current_string
+      @current_string << CGI.unescapeHTML(value) if @current_string
     end
 
   end

diff --git a/spec/data/Spec.xlsx b/spec/data/Spec.xlsx
diff --git a/spec/workbook_spec.rb b/spec/workbook_spec.rb
@@ -47,8 +47,8 @@
   it 'Shared strings' do
     Workbook.open filename do |w|
       w.should have(56).shared_strings
-      w.shared_strings[0].should eq 'LevenshteinDistance'
-      w.shared_strings[55].should eq 'TST_ModMan_Insulto_SU_Normal'
+      w.shared_strings.should include 'LevenshteinDistance'
+      w.shared_strings.should include 'TST_ModMan_Insulto_SU_Normal'
     end
   end