Include zero count active facets in facet options #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristopherChudzicki
force-pushed
the
cc/zero-count
branch
from
ae766eb to
a70a9ec
Compare
Comment on lines
-2
to
+3
| import { shallow } from "enzyme" | ||
| import { render, screen, within } from "@testing-library/react" | ||
| import user from "@testing-library/user-event" |
There was a problem hiding this comment.
The vast majority of the line changes in this PR are from removing enzyme in this test file, and adding @testing-library/react, @testing-library/user-event.
I was going to add more tests in this file, and I did not want to add enzyme tests since they are fragile / don't work with React 17, 18. (In previous PR, I had to alter the test file because I extracted AvailableFacets from FacetDisplay https://github.com/mitodl/course-search-utils/pull/78/files#diff-0b2ec90271aa9923bd1a4e5747946849aa084238d325cc529cda4848f503b8a3). So I rewrote the enzyme tests with @testing-library.
I also added some tests... E.g., I didn't see tests for clicking the expand/collapse buttons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
For mitodl/mit-learn#675
Description (What does it do?)
Screenshots (if appropriate):
Note the zero-count active checkbox
How can this be tested?
Using mitodl/mit-learn#675, activate a search filter then EITHER:
The active filter should still show in the facet options list.