Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ MITx - Theme 101 ] Move invitation(allowed_enroll) emails from edx_ace to Bulk emails templates #154

Closed
wants to merge 14 commits into from

Conversation

umarmughal824
Copy link

@umarmughal824 umarmughal824 commented Nov 29, 2019

ichuang and others added 13 commits October 23, 2019 10:08
(cherry picked from commit ebf034b)
This is aggregating a collection of changes for adding a tab to the instructor dashboard for reporting on submissions to rapid response problems.
* Enhance courses page performance in system admin page

(cherry picked from commit 39b56c4)
(cherry picked from commit d0c9f9d)
Trying to load the grade distribution for a given block is resulting in full table scans on the `courseware_studentmodule` table which contains over 15 million rows. This causes the page load to time out, as well as blocking other processes from accessing the table in a timely fashion.

(cherry picked from commit 8b69081)
(cherry picked from commit 787a215)
(cherry picked from commit e3a9604)
(cherry picked from commit 900a119)
In order to allow for preventing users accidentally enrolling in a course we are adding a flag to toggle whether courses in a given installation of edx-platform are invite only, rather than relying on setting it at the per-course level.

(cherry picked from commit 1be29e2)
(cherry picked from commit 2581b511ceb44c6f6677ece4bf833c556fe766f0)
Because CAS creates the user with `is_active` and `email` already set there is no change in those fields. By adding `date_joined` to the list of fields checked the auto enrollment will be processed properly.

(cherry picked from commit 26307bf)
Updating edxval to use our modified version to fix transcript export
@umarmughal824 umarmughal824 changed the title move invitation(allwed_enroll) emails from edx_ace to Bulk emails tem… move invitation(allwed_enroll) emails from edx_ace to Bulk emails templates Nov 29, 2019
@umarmughal824 umarmughal824 changed the title move invitation(allwed_enroll) emails from edx_ace to Bulk emails templates [ MITx - Theme 101 ] Move invitation(allwed_enroll) emails from edx_ace to Bulk emails templates Nov 29, 2019
@umarmughal824 umarmughal824 changed the title [ MITx - Theme 101 ] Move invitation(allwed_enroll) emails from edx_ace to Bulk emails templates [ MITx - Theme 101 ] Move invitation(allowed_enroll) emails from edx_ace to Bulk emails templates Nov 29, 2019
@pdpinch
Copy link
Member

pdpinch commented Dec 2, 2019

I don't understand what this PR is for? The link in the description goes to an issue about problems, not email.

@umarmughal824
Copy link
Author

problems

sorry, it was a typo, the description is updated now.

@pdpinch
Copy link
Member

pdpinch commented Mar 25, 2020

@umarmughal824 this PR is really stale now and I'm not sure we even want to make changes to this mail template any more. I'm going to close this.

@pdpinch pdpinch closed this Mar 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants