Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add canvas integration support (#300) #319

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

arslanashraf7
Copy link

@arslanashraf7 arslanashraf7 commented Oct 28, 2024

Relevant ticket

https://github.com/mitodl/hq/issues/5862

Description

Cherry-picked and resolved conflicts from 7a2edd5

NOTE: I have reduced as much code and migrated it to (https://github.com/mitodl/open-edx-plugins/tree/main/src/ol_openedx_canvas_integration) as much as possible.

Testing instructions

NOTE: I've removed some lines about displaying the time past time on the date column e.g. (An hour ago) since that was not needed or important enough to keep in our cherry-pick

Copy link

@asadali145 asadali145 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@arslanashraf7 arslanashraf7 force-pushed the arslan/5862-canvas-pick branch 2 times, most recently from c5bc14d to 6bfc6a5 Compare November 15, 2024 13:24
@arslanashraf7 arslanashraf7 force-pushed the arslan/5862-canvas-pick branch from 6bfc6a5 to b557084 Compare November 15, 2024 14:02
@arslanashraf7 arslanashraf7 merged commit d699b47 into mitx/sumac Nov 18, 2024
47 checks passed
@arslanashraf7 arslanashraf7 deleted the arslan/5862-canvas-pick branch November 18, 2024 10:37
blarghmatey pushed a commit that referenced this pull request Nov 18, 2024
* feat: add canvas integration support
blarghmatey pushed a commit that referenced this pull request Dec 2, 2024
* feat: add canvas integration support
blarghmatey pushed a commit that referenced this pull request Dec 3, 2024
* feat: add canvas integration support
feoh pushed a commit that referenced this pull request Dec 9, 2024
* feat: add canvas integration support
blarghmatey pushed a commit that referenced this pull request Dec 16, 2024
* feat: add canvas integration support
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants