forked from openedx/edx-platform
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add canvas integration support (#300) #319
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arslanashraf7
force-pushed
the
arslan/5862-canvas-pick
branch
from
October 30, 2024 09:16
2519344
to
3a4d591
Compare
arslanashraf7
force-pushed
the
arslan/5862-canvas-pick
branch
from
November 6, 2024 14:03
77336f7
to
449572b
Compare
arslanashraf7
force-pushed
the
arslan/5862-canvas-pick
branch
from
November 6, 2024 14:14
76e6482
to
8e40853
Compare
arslanashraf7
force-pushed
the
arslan/5862-canvas-pick
branch
from
November 14, 2024 12:39
6133144
to
b76c99e
Compare
arslanashraf7
force-pushed
the
arslan/5862-canvas-pick
branch
from
November 14, 2024 12:58
b76c99e
to
bf82af1
Compare
asadali145
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
arslanashraf7
force-pushed
the
arslan/5862-canvas-pick
branch
2 times, most recently
from
November 15, 2024 13:24
c5bc14d
to
6bfc6a5
Compare
arslanashraf7
force-pushed
the
arslan/5862-canvas-pick
branch
from
November 15, 2024 14:02
6bfc6a5
to
b557084
Compare
asadali145
approved these changes
Nov 15, 2024
blarghmatey
pushed a commit
that referenced
this pull request
Nov 18, 2024
* feat: add canvas integration support
blarghmatey
pushed a commit
that referenced
this pull request
Dec 2, 2024
* feat: add canvas integration support
blarghmatey
pushed a commit
that referenced
this pull request
Dec 3, 2024
* feat: add canvas integration support
feoh
pushed a commit
that referenced
this pull request
Dec 9, 2024
* feat: add canvas integration support
blarghmatey
pushed a commit
that referenced
this pull request
Dec 16, 2024
* feat: add canvas integration support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant ticket
https://github.com/mitodl/hq/issues/5862
Description
Cherry-picked and resolved conflicts from 7a2edd5
NOTE: I have reduced as much code and migrated it to (https://github.com/mitodl/open-edx-plugins/tree/main/src/ol_openedx_canvas_integration) as much as possible.
Testing instructions
NOTE: I've removed some lines about displaying the time past time on the date column e.g. (
An hour ago
) since that was not needed or important enough to keep in our cherry-pick