Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix : error on file upload #362

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ichintanjoshi
Copy link

post.success is not a function any more.

https://stackoverflow.com/questions/46394793/typeerror-post-success-is-not-a-function

What are the relevant tickets?

None

What's this PR do?

This will allow to upload the files, as of now if we try to use file upload function, it does not work. After this change it works back to normal

How should this be manually tested?

Just try to upload the file with this change and without this change.

Where should the reviewer start?

It's a minor .js file change so shouldn't be much effort

Any background context you want to provide?

I was trying to upload the file by using this block for one of the clients and it did not work .

After some digging around I found this error TypeError: $.post(...).success is not a function

Which lead me to https://stackoverflow.com/questions/46394793/typeerror-post-success-is-not-a-function

And the solution as well.

What GIF best describes this PR or how it makes you feel?

https://tenor.com/VK0g.gif

@asadali145 asadali145 self-assigned this Nov 4, 2024
@asadali145
Copy link

Hey @ichintanjoshi,

I was trying to reproduce the issue but I could not. I tried Firefox and Opera with a local Devstack setup.

Could you please share more details on your environment? Have you tried reproducing it locally with Devstack OR Tutor?
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants