Redirect new users to onboarding flow #2186
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OpenAPI ChangesShow/hide 24 changes: 0 error, 0 warning, 24 info |
shanbady
changed the title
shanbady
added
Needs Review
OpenAPI ChangesShow/hide 24 changes: 0 error, 0 warning, 24 info |
OpenAPI ChangesShow/hide 24 changes: 0 error, 0 warning, 24 info |
rhysyngsun
requested changes
Apr 9, 2025
There was a problem hiding this comment.
A few small things, but you might not need to do them if we do the following suggestion:
I noticed that when the site loads you see a flash of the content followed by the redirect over to /onboarding. I hadn't thought of this when I wrote out the issue but I'm thinking that maybe we instead want to take care of this on the login view in the backend instead. Something along the lines of this:
class CustomLoginView(View):
"""
Redirect the user to the appropriate url after login
"""
def get(
self,
request,
*args, # noqa: ARG002
**kwargs, # noqa: ARG002
):
"""
GET endpoint for logging a user in.
"""
redirect_url = get_redirect_url(request)
if (
not request.user.profile.completed_onboarding
and not request.GET.get("skip_onboarding", "0") == "1"
):
# redirect the user to onboarding and later to the next url
params = urlencode({"next": redirect_url})
redirect_url = f"{settings.NEW_USER_REDIRECT_URL}?{params}"
return redirect(redirect_url)This also passes along the next parameter to the onboarding flow, I can't recall if we handle that, but we should if we don't so the user ends up where they left off.
| @@ -171,7 +169,7 @@ const OnboardingPage: React.FC = () => { | |||
| if (activeStep < NUM_STEPS - 1) { | |||
| setActiveStep((prevActiveStep) => prevActiveStep + 1) | |||
| } else { | |||
| router.push(DASHBOARD_HOME) | |||
| ;(window as Window).location = DASHBOARD_HOME | |||
There was a problem hiding this comment.
Could you explain why this change was needed?
There was a problem hiding this comment.
Yea - basically there was some caching of data that happens with the profile query such that when we update the completed_onboarding it reads the cached value on the subsequent page unless we do a full reload. I spoke with @ChristopherChudzicki and it seemed like the full reload was the easiest way since we only should ever do this once per user
| !user?.profile?.completed_onboarding && | ||
| pathname !== urls.ONBOARDING | ||
| ) { | ||
| if (typeof profileMutate === "function") { |
There was a problem hiding this comment.
I'm a bit confused why this would ever not be a function?
There was a problem hiding this comment.
I was running into some error previously but I think its removable since I moved this into useEffect. removed
OpenAPI ChangesShow/hide 24 changes: 0 error, 0 warning, 24 info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/6857
Description (What does it do?)
This PR adds a "completed_onboarding" flag to the user profile that gets set to True once the user has interacted with the onboarding page after they first login.
How can this be tested?
test the "skip_onboarding" get parameter which skips the onboarding.