-
Notifications
You must be signed in to change notification settings - Fork 4
fix: Continue summarizer on error and add more logging #2220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
OpenAPI ChangesShow/hide No detectable change.
|
ed0138d
to
0caed68
Compare
OpenAPI ChangesShow/hide No detectable change.
|
@@ -101,6 +101,7 @@ services: | |||
environment: | |||
- KEYCLOAK_ADMIN=${KEYCLOAK_SVC_ADMIN:-admin} | |||
- KEYCLOAK_ADMIN_PASSWORD=${KEYCLOAK_SVC_ADMIN_PASSWORD:-admin} | |||
- "_JAVA_OPTIONS=${JAVA_OPTIONS:-}" # Load _JAVA_OPTIONS from env, fallback to empty string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OpenAPI ChangesShow/hide No detectable change.
|
78e7e84
to
50d5f96
Compare
OpenAPI ChangesShow/hide No detectable change.
|
50d5f96
to
3926dfe
Compare
OpenAPI ChangesShow/hide No detectable change.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Worked as expected after syncing to set up initial fixtures properly. As discussed it might be worth adding docs on how to set this up or adding some default fixtures for local envs in a separate pr.
What are the relevant tickets?
https://github.com/mitodl/hq/issues/7123
Description (What does it do?)
ARM64
archScreenshots (if appropriate):
How can this be tested?\
Testing summarize fix
main
branch, you can follow the steps in https://github.com/mitodl/hq/issues/7123 OR do the below[max_tokens](https://github.com/mitodl/mit-learn/blob/main/learning_resources/content_summarizer.py#L238)
so that the flashcards response from the LLM would not be complete because of lowmax_tokens
. The JSON response will cut off in the middle and fail the flashcards JSON format validation. See More details in the ticket.max_tokens
, make sure you do not set it so low that this fails on the prompt. It should be reasonable enough that the prompt gets through and but their response from LLM breaks.max_tokens
value, but the command will not halt, and it should process all the remaining files.Testing Keycloak fix on ARM64 machine
Keycloak
container should run without any errors (Ideal, if you could check it on a container built fresh)Additional Context