fix: external sync when there is no platform with passed name #3385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arslanashraf7
force-pushed
the
arslan/fix-external-sync
branch
from
b49c0c4 to
aef70d4
Compare
arslanashraf7
commented
Jan 24, 2025
| self.stdout.write(self.style.ERROR(f"Unknown vendor name {vendor_name}.")) | ||
| return | ||
|
|
||
| platform = Platform.objects.filter(name__iexact=vendor_name).first() | ||
| if platform and not platform.enable_sync and not options.get("force"): |
There was a problem hiding this comment.
The existence of the platform will be checked on line 38.
arslanashraf7
force-pushed
the
arslan/fix-external-sync
branch
from
aef70d4 to
740f0e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the relevant tickets?
None, Noticecd this issue while working on another ticket.
Description (What does it do?)
Fixes a bug when we run the command with a non-existent platform name (i.e. exists in the platform mapping but doesn't exist in the system). The command would bypass the missing platform in the system, and the sync flag and run right away.
I've separated the errors to be clearer in stating what problem occurred while running the command. 1. Is the database record missing? 2) Is the mapping missing 3) Is the sync off
Screenshots (if appropriate):
How can this be tested?
Additional Context