Merge pull request #53 from mitre/fix/operation_data_network_usage

Refactored operation polling to only request active operation
mitre · Jun 7, 2024 · 478744c · 478744c
2 parents b5f7315 + fd87628
commit 478744c
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 3 deletions.
diff --git a/src/stores/operationStore.js b/src/stores/operationStore.js
@@ -27,6 +27,15 @@ export const useOperationStore = defineStore("operationStore", {
         console.error("Error fetching operations", error);
       }
     },
+    async getOperation($api, operationID) {
+        try {
+          const response = await $api.get(`/api/v2/operations/${operationID}`);
+          let operation = response.data;
+          this.operations[operation.id] = operation;
+        } catch (error) {
+          console.error("Error fetching operations", error);
+        }
+      },
     async createOperation($api, operation) {
       try {
         const response = await $api.post("/api/v2/operations", operation);

diff --git a/src/views/OperationsView.vue b/src/views/OperationsView.vue
@@ -190,13 +190,14 @@ const resetFilter = () => {
 };
 
 function selectOperation() {
-  //TODO: Stop updating if operation is finished
   if (updateInterval) clearInterval(updateInterval);
   if (operationStore.selectedOperationID === "") return;
   resetFilter();
   updateInterval = setInterval(async () => {
-    if (operationStore.selectedOperationID !== "") {
-      await operationStore.getOperations($api);
+    if (operationStore.selectedOperationID !== "" &&
+        operationStore.operations[operationStore.selectedOperationID].state !== "finished")
+    {
+      await operationStore.getOperation($api, operationStore.selectedOperationID);
     } else {
       clearInterval(updateInterval);
     }