Remove VITE_CALDERA_URL and use window.location.origin to route API requests #67
+2
−9
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
window.location.origin
to decide where to route API requests.VITE_CALDERA_URL adds complexity with no clear benefit. It is very easy to misconfigure (especially when magma was built outside of container, the .env file was changed, and then the Docker container was built). When it is misconfigured, there is no error and the UI just seems unresponsive.
Due to CORS and tight coupling between caldera and magma, it is very unlikely that the URL is going to be anything other than the value held in
window.location.origin
. In all other scenarios, a reverse proxy should be used.