-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
log a few images to tensorboard #485
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making my comment in #482 into this PR. The code looks even more understandable than I expected :) (I haven't tested it myself, but I assume it works.)
I wonder if it makes sense to log the number of the sample in the train_set
, i.e. the result of np.random.randint
instead of or next to the i
, so that it can be looked up more easily? If the train_set
is shuffled or if the dataset is an Arrow file, then this number would not map to an image that you can look up easily.
Perhaps the logging of images could be made optional too, by adding a CLI option that sets the max number of logged images to 0 by default. You could refer to that number instead of 16.
Just an additional comment: this would be a wonderful thing to also log the prediction with it :) |
Because the samples might be substituted on the fly if loading them fails for any reason the indices might not actually correspond to the order of the dataset. And as a note you can unpack a binary dataset with |
I now also added logging for validation images and their prediction. How do you feel about adding another parameter to control the image logging? |
…n for other formats
No description provided.