-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax requirements for scipy #578
base: main
Are you sure you want to change the base?
Conversation
Python 3.8 only supports scipy 1.10, but newer Python versions like 3.11 also work fine with scipy 1.11. Signed-off-by: Stefan Weil <[email protected]>
Maybe we could even relax the requirements further. Meanwhile there exists scipy 1.12.0, and I could run the tests with that newer release:
|
@@ -47,7 +47,7 @@ install_requires = | |||
numpy~=1.23.0 | |||
Pillow>=9.2.0 | |||
regex | |||
scipy~=1.10.0 # bump up to latest release with py3.8 EOL | |||
scipy>1.10.0,<1.12.0 # remove 1.10 with py3.8 EOL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
scipy>1.10.0,<1.12.0 # remove 1.10 with py3.8 EOL | |
scipy>1.10.0,<1.12.99 # remove 1.10 with py3.8 EOL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optionally the latest release scipy 1.12.0 can also be allowed.
Do you need that relaxation for some specific reason? I've basically arrived at the point where all the dependencies are pinned as anything looser tends to break sooner or later. Especially libraries depending on scipy like scikit-image do not define their working versions correctly so I'd rather remain at an ensemble of releases that I know won't cause any trouble. |
I prepared the pull request because we got a report from someone who had the issue described in #525. But currently I see no urgent need for a relaxation: both OCR-D and eScriptorium don't require it. So it's fine for me to wait with this pull request until it is really needed. |
Python 3.8 only supports scipy 1.10, but newer Python versions like 3.11 also work fine with scipy 1.11.