Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore/ci: linter with reviewdog #625

Merged
merged 5 commits into from
Dec 15, 2024
Merged

Conversation

miurahr
Copy link
Owner

@miurahr miurahr commented Nov 5, 2024

Pull request type

select from below

  • Build and release changes

Which ticket is resolved?

What does this PR change?

  • Add linter github action

Other information

Copy link

codacy-production bot commented Dec 14, 2024

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e701799) 3514 3087 87.85%
Head commit (3aba133) 3514 (+0) 3087 (+0) 87.85% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#625) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@coveralls
Copy link

coveralls commented Dec 14, 2024

Coverage Status

coverage: 87.365%. remained the same
when pulling 3aba133 on topic/miurahr/use-reviewdog-for-pr
into e701799 on master.

- add separate linter github actions
- add reviewdog installer shell
- update .gitignore fir ./bin folder
@miurahr miurahr force-pushed the topic/miurahr/use-reviewdog-for-pr branch from 4b6df1f to 39e59d5 Compare December 15, 2024 03:39
Signed-off-by: Hiroshi Miura <[email protected]>
- Add .reviewdog.yml
- Update github actions script
@miurahr miurahr merged commit d98b916 into master Dec 15, 2024
30 checks passed
@miurahr miurahr deleted the topic/miurahr/use-reviewdog-for-pr branch December 15, 2024 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants