Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding user_id field with every event and people updates #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

adding user_id field with every event and people updates #45

wants to merge 1 commit into from

Conversation

dneralla
Copy link

No description provided.

@jbwyme
Copy link
Contributor

jbwyme commented Jul 8, 2019

I don't think we want to do this. AFAIK Mixpanel does not have a special $user_id reserved property. You can, of course, register this as a super property if you'd like in your own implementation.

@jbwyme jbwyme closed this Jul 8, 2019
@jbwyme jbwyme reopened this Jul 9, 2019
@jbwyme
Copy link
Contributor

jbwyme commented Jul 9, 2019

Ah I did not realize this was related to our ingestion ID mapping updates. I'm happy to merge this in but I believe the tests need to be updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dneralla @jbwyme