Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library: document new text filter operator '=' (find exact matches) #590

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Oct 11, 2023

@ronso0 ronso0 requested a review from Swiftb0y October 11, 2023 22:23
source/chapters/library.rst Outdated Show resolved Hide resolved
source/chapters/library.rst Outdated Show resolved Hide resolved
@ronso0 ronso0 marked this pull request as draft October 11, 2023 22:32
@ronso0 ronso0 marked this pull request as ready for review October 11, 2023 22:33
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. thank you for cleaning up the loose ends. Any1 else wanting to review?

@daschuer
Copy link
Member

I am missing something like the PR headline in the text.

@ronso0
Copy link
Member Author

ronso0 commented Oct 12, 2023

What exactly do you have in mind?

IMHO this is clarified with

You can use the = operator to find only tracks where the entire property text equals the search term.

Note that this is just an extension, not an entirely new feature which would deserve more emphasis.

@@ -413,6 +413,19 @@ Mixxx supports the following filters:
It doesn't matter if you have space between the colon and the argument
or not. Quotes must be used for multi-word text arguments.

You can use the **=** operator to find only tracks where the entire property
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
You can use the **=** operator to find only tracks where the entire property
You can use **=** for finding exact matches. It reveals only tracks where the entire property

@ronso0
Copy link
Member Author

ronso0 commented Oct 12, 2023

Alright, done.

Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@daschuer daschuer merged commit 0c4da76 into mixxxdj:2.4 Oct 12, 2023
8 checks passed
@ronso0 ronso0 deleted the search-exact branch October 12, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants