Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

document new effect controls #612

Merged
merged 2 commits into from
Feb 29, 2024
Merged

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Feb 5, 2024

Closes #501

There are some more in #261

@ronso0 ronso0 added the effects label Feb 5, 2024
source/chapters/appendix/mixxx_controls.rst Outdated Show resolved Hide resolved
source/chapters/appendix/mixxx_controls.rst Outdated Show resolved Hide resolved
@Swiftb0y
Copy link
Member

@ronso0 it seems you forgot to push 😅

@ronso0
Copy link
Member Author

ronso0 commented Feb 16, 2024

really weird, in the manual (and website) repo I overlook the git errors. will push

@ronso0 ronso0 force-pushed the effects-new-controls branch 2 times, most recently from b809018 to ad91e99 Compare February 16, 2024 09:57
@ronso0
Copy link
Member Author

ronso0 commented Feb 16, 2024

precommit fails due to the 'double-click' typo

@ronso0 ronso0 force-pushed the effects-new-controls branch 2 times, most recently from 071f1cd to ba85033 Compare February 16, 2024 13:27
@ronso0 ronso0 force-pushed the effects-new-controls branch 2 times, most recently from bb96bd1 to d84d13c Compare February 16, 2024 15:20
@Swiftb0y
Copy link
Member

also, rebasing would be nice for the other checks.

@ronso0 ronso0 force-pushed the effects-new-controls branch from d84d13c to de6d7f7 Compare February 28, 2024 10:37
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last comments, sorry for going back and forth, I wish I would spot all of these issues on the first review.

source/chapters/appendix/mixxx_controls.rst Outdated Show resolved Hide resolved
source/chapters/appendix/mixxx_controls.rst Show resolved Hide resolved
@ronso0 ronso0 force-pushed the effects-new-controls branch from de6d7f7 to e6985a5 Compare February 29, 2024 00:46
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Swiftb0y Swiftb0y merged commit 4c9f5b8 into mixxxdj:2.4 Feb 29, 2024
8 of 9 checks passed
@ronso0 ronso0 deleted the effects-new-controls branch February 29, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants