-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
document new effect controls #612
Conversation
@ronso0 it seems you forgot to push 😅 |
really weird, in the manual (and website) repo I overlook the git errors. will push |
b809018
to
ad91e99
Compare
precommit fails due to the 'double-click' typo |
071f1cd
to
ba85033
Compare
bb96bd1
to
d84d13c
Compare
also, rebasing would be nice for the other checks. |
d84d13c
to
de6d7f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last comments, sorry for going back and forth, I wish I would spot all of these issues on the first review.
Co-authored-by: Swiftb0y <[email protected]>
de6d7f7
to
e6985a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
Closes #501
There are some more in #261