fix: don't try to deepMerge read-only properties

mixxxdj · Jan 20, 2025 · 3b16e7c · 3b16e7c
1 parent c327cf1
commit 3b16e7c
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/res/controllers/common-controller-scripts.js b/res/controllers/common-controller-scripts.js
@@ -178,6 +178,10 @@ const deepMerge = function(target, source) {
         target.push(...Object.values(objTarget));
     } else if (isSimpleObject(target) && isSimpleObject(source)) {
         Object.keys(source).forEach(key => {
+            // ensure the property is not read-only, if so skip it.
+            if (!Object.getOwnPropertyDescriptor(source, key).writable) {
+                return;
+            }
             if (
                 Array.isArray(target[key]) && Array.isArray(source[key]) ||
               isSimpleObject(target[key]) && isSimpleObject(source[key])