Apply suggestions from code review

Co-authored-by: Swiftb0y <[email protected]>
mixxxdj · Nov 11, 2024 · 490ed19 · 490ed19
1 parent faa76d0
commit 490ed19
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/engine/controls/macrocontrol.cpp b/src/engine/controls/macrocontrol.cpp
@@ -15,7 +15,7 @@ const QRegExp kAutoGeneratedLabelRegExp(QStringLiteral("[0-9. ]+(\\[\\w*\\])?"))
 } // namespace
 
 ConfigKey MacroControl::getConfigKey(const QString& name) {
-    return ConfigKey(m_group, QStringLiteral("macro_%1_%2").arg(m_slot).arg(name));
+    return ConfigKey(m_group, QStringLiteral("macro_%1_%2").arg(m_slot, name));
 }
 
 MacroControl::MacroControl(const QString& group, UserSettingsPointer pConfig, int slot)

diff --git a/src/track/macro.cpp b/src/track/macro.cpp
@@ -95,7 +95,7 @@ void Macro::addAction(const MacroAction& action) {
 
 mixxx::audio::FramePos Macro::getStart() const {
     VERIFY_OR_DEBUG_ASSERT(!getActions().isEmpty()) {
-        return mixxx::audio::FramePos(0);
+        return mixxx::audio::FramePos();
     }
     return m_actions.first().getTargetPosition();
 }

diff --git a/src/track/macroaction.h b/src/track/macroaction.h
@@ -12,7 +12,7 @@ namespace proto = mixxx::track::io;
 /// but that is subject to change.
 class MacroAction {
   public:
-    enum class Type : uint32_t {
+    enum class Type {
         Jump = 0
     };