fixup! refactor: slim down valuetransformer.h and auto memory management

mixxxdj · Nov 8, 2024 · edb85f9 · edb85f9
1 parent 2d9821d
commit edb85f9
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/src/util/valuetransformer.cpp b/src/util/valuetransformer.cpp
@@ -93,7 +93,7 @@ double ValueTransformer::transform(double argument) const {
             m_transformers.cend(),
             argument,
             [&](double argument, const auto& pNode) {
-                return pNode->transformInverse(argument);
+                return pNode->transform(argument);
             });
 }
 
@@ -113,6 +113,7 @@ std::unique_ptr<ValueTransformer> ValueTransformer::parseFromXml(
         return nullptr;
     }
 
+    // constructor is private, so we can't use std::make_unique
     auto pTransformer = std::unique_ptr<ValueTransformer>(new ValueTransformer());
 
     auto maybeAddFromElement = [&]<typename T>(auto element) {
@@ -134,6 +135,7 @@ std::unique_ptr<ValueTransformer> ValueTransformer::parseFromXml(
         QDomElement element = node.toElement();
         QString name = element.nodeName();
         if (name == "Invert") {
+
             pTransformer->addTransformer(std::make_unique<TransformInvert>());
         } else if (name == "Add") {
             maybeAddFromElement.operator()<TransformAdd>(element);