Overview: clear pickup position display when opening cue menu #13693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
requested changes
Sep 26, 2024
src/widget/woverview.cpp
Outdated
Comment on lines
597
to
598
| QEvent* ev = new QEvent(QEvent::HoverLeave); | ||
| leaveEvent(ev); |
There was a problem hiding this comment.
ev is leaked. This should do the trick:
Suggested change
| QEvent* ev = new QEvent(QEvent::HoverLeave); | |
| leaveEvent(ev); | |
| QEvent ev = QEvent(QEvent::HoverLeave); | |
| leaveEvent(&ev); |
There was a problem hiding this comment.
Thank you.
I definitly have to do some homework wrt pointers.
There was a problem hiding this comment.
when in doubt, never write "new" :).
ronso0
force-pushed
the
overview-clear-pickup-pos
branch
from
1e217b1 to
3d8627b
Compare
ronso0
force-pushed
the
overview-clear-pickup-pos
branch
from
3d8627b to
af6057b
Compare
ywwg
approved these changes
Dec 18, 2024
src/widget/woverview.cpp
Outdated
| @@ -592,6 +592,10 @@ void WOverview::mousePressEvent(QMouseEvent* e) { | |||
| m_pCurrentTrack->removeCue(pHoveredCue); | |||
| return; | |||
| } else { | |||
| // Clear the pickup position display. | |||
| // ev could actually be any event type, it's not used anyway. | |||
There was a problem hiding this comment.
if it's not used can we pass nullptr?
ronso0
force-pushed
the
overview-clear-pickup-pos
branch
from
af6057b to
95536c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO it only adds noise, all relevant info like the cue position is displayed in the cue menu.