-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(POC) LateNight: allow to show 4 decks in a row #13724
base: 2.5
Are you sure you want to change the base?
Conversation
3303c10
to
f422ed5
Compare
very nice! |
Thanks. Nice, but not polished yet. Yes, two flat white with sugar and a glass of water. |
FWIW, changing the deck order (3 1 2 4 or 1 2 3 4) can be done with color schemes and deck num variables, ie. requires skin reload to update the deck numbers in each deck/waveform template. For LateNight we'd then have
with almost exact duplicate themes. Idk if that's worth it. Is this a desired feature? Idk. |
The demand for 1234 is only sourced by certain controllers. With "wrong" labeling. right? Is switching between 3124 and 1234 a mapping feature? We need probably also swap the deck xfader orientation. Do we know which controller are affected? |
It's not only for certain controllers. |
Yes, probably. And we don't have deck number labels, but we do have the "LoadToDeck#" controls, and with external mixers one has to map mixer <--> Mixxx numbers twice: for the mapping and for the deck sound I/O configuration. Needs to be done only once, so yeah, maybe it's too much complexity considering the little demand. |
d286562
to
8865ca4
Compare
8865ca4
to
ef5fbbf
Compare
I was not aware that a certain order prevents people from using deck 3 and 4. In general we should make all users feel at home with Mixxx. Unfortunately the issue is more complex that it may seem. We need to consider switching from:
To
And take 1234 and 3124 labeled controllers into account. I consider a wrong labeling more a mental issue than a surprising order. So how about file an issue for that and solve it independently for all skins? |
Definitely appreciated. Thank you. |
A fun (two-) coffee break hack.
Looks okay, please test and let me know what you think.
TODO