Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog for 2.4.2 #13823

Merged
merged 1 commit into from
Nov 10, 2024
Merged

Changelog for 2.4.2 #13823

merged 1 commit into from
Nov 10, 2024

Conversation

daschuer
Copy link
Member

@daschuer daschuer commented Nov 2, 2024

Here a step towards overdue 2.4.2 release.

@daschuer daschuer force-pushed the changelog_242 branch 2 times, most recently from 1fea241 to 7b61026 Compare November 3, 2024 20:55
@daschuer
Copy link
Member Author

daschuer commented Nov 3, 2024

Updated with latest merges.

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
Found some nits, didn't yet check the PR/issue links

CHANGELOG.md Outdated
Comment on lines 66 to 68
* Fix wrong pitch slider value on startup
[#11814](https://github.com/mixxxdj/mixxx/issues/11814)
[#13463](https://github.com/mixxxdj/mixxx/pull/13463)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Duplicate, it's already listed above

Suggested change
* Fix wrong pitch slider value on startup
[#11814](https://github.com/mixxxdj/mixxx/issues/11814)
[#13463](https://github.com/mixxxdj/mixxx/pull/13463)

CHANGELOG.md Outdated
@@ -4,14 +4,26 @@

### Controller Mappings

* Denon MC7000: Fix star up/down logic by only handling button down events [#13588](https://github.com/mixxxdj/mixxx/pull/1358)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Denon MC7000: Fix star up/down logic by only handling button down events [#13588](https://github.com/mixxxdj/mixxx/pull/1358)
* Denon MC7000: Fix star up/down logic by only handling button down events [#13588](https://github.com/mixxxdj/mixxx/pull/13588)

CHANGELOG.md Outdated
[#13610](https://github.com/mixxxdj/mixxx/pull/13610)
* Controller engine: Unify/improve logging, expand error dialog's Details box
[#13626](https://github.com/mixxxdj/mixxx/pull/13626)
* Fix quantization in the effect engine (mentronome effect)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Fix quantization in the effect engine (mentronome effect)
* Fix quantization in the effect engine (metronome effect)

@daschuer
Copy link
Member Author

daschuer commented Nov 8, 2024

I have amend the fix. Once this is merged we can proceed with the release.

Does one want to take care of the remaining bugs before:
https://github.com/mixxxdj/mixxx/milestones/2.4.2

Swiftb0y

This comment was marked as outdated.

@daschuer
Copy link
Member Author

@ronso0 Can this be merged now?

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@ronso0 ronso0 merged commit 2f93444 into mixxxdj:2.4 Nov 10, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants