Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracks: focus the editing field in the track properties that corresponds to the focused column #13841

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Nov 5, 2024

Just a small helper for the editing workflow.
(it's just the equivalent to the flow with the track labels in decks, see

void WTrackProperty::mouseDoubleClickEvent(QMouseEvent* pEvent) {
Q_UNUSED(pEvent);
if (!m_pCurrentTrack) {
return;
}
ensureTrackMenuIsCreated();
m_pTrackMenu->loadTrack(m_pCurrentTrack, m_group);
m_pTrackMenu->showDlgTrackInfo(m_displayProperty);
}
)

  • in the tracks table the 'Comment' column is focused
  • hit Ctrl+Enter to open Track Properties (one or more tracks)
  • Track Properties opens and keyboard focus is on the Comment field

@ronso0
Copy link
Member Author

ronso0 commented Dec 17, 2024

completely wrong commit..
will check if I find it again.

@ronso0 ronso0 marked this pull request as draft December 17, 2024 17:10
@ronso0 ronso0 force-pushed the track-info-focus-clicked-table-item branch from a33f6a6 to 57588b4 Compare December 17, 2024 22:59
@ronso0 ronso0 changed the base branch from main to 2.5 December 17, 2024 22:59
@ronso0
Copy link
Member Author

ronso0 commented Dec 17, 2024

here we go!

2.5 or 2.5.1, I don't mind

@ronso0 ronso0 marked this pull request as ready for review December 17, 2024 22:59
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works and Looks good.

Do we want have the same for the track context menu?

@daschuer daschuer merged commit a34760b into mixxxdj:2.5 Dec 18, 2024
13 checks passed
@ronso0
Copy link
Member Author

ronso0 commented Dec 18, 2024

🤔

@ronso0
Copy link
Member Author

ronso0 commented Dec 18, 2024

👍

@ronso0 ronso0 deleted the track-info-focus-clicked-table-item branch December 18, 2024 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants