Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) Pref Mixer: fix crossader graph #13848

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Nov 7, 2024

This restores the xfader graph.
The xfader graph scene was to small since e6d4a2a (QtDesigner auto-changes I suppose):
image
Noticed with qt 6.2.3

@ronso0 ronso0 added this to the 2.6-beta milestone Nov 7, 2024
Comment on lines -165 to +166
<property name="fixedSize" stdset="0">
<property name="fixedSize">
Copy link
Member

@Swiftb0y Swiftb0y Nov 8, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just out of curiosity, any idea what stdset="0" is supposed to do? I couldn't find anything online.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, I didn't do a research. Tbh I'm a tired of debugging Qt quirks, crawling Qt forums, and I only have 6.2.3 to test with. So as long as it looks as intended on all platforms 🤷‍♂️

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no worries.

Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets merge and verify this does what it supposed to do during beta

@Swiftb0y Swiftb0y merged commit 9bb5d8c into mixxxdj:main Nov 9, 2024
13 checks passed
@ronso0 ronso0 deleted the pref-mixer-fix-xfader-graphic-size branch November 9, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants