Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update skin preview images #14044

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

daschuer
Copy link
Member

No description provided.

@daschuer daschuer added this to the 2.5.0 milestone Dec 20, 2024
@github-actions github-actions bot added the skins label Dec 20, 2024
@ronso0 ronso0 marked this pull request as draft December 20, 2024 18:31
@ronso0
Copy link
Member

ronso0 commented Dec 20, 2024

unfortunately we can't use these screens: colors are not correct, library font is custom
See https://mixxx.zulipchat.com/#narrow/channel/109171-development/topic/2.2E5.2E0.20release.20deadline/near/490199318

@ronso0
Copy link
Member

ronso0 commented Dec 22, 2024

These are still the images with the screen calibration by @Eve00000 , ie. wrong colors.
See this diff for example
image

@ronso0
Copy link
Member

ronso0 commented Dec 22, 2024

Actually, the only difference 2.4 --> 2.5 I can spot at a glance in the previews are

  • the new effect unit menu button
  • no menubar anymore

Layout / features shown in the old screens is much better than the new ones.
After all the previews shoud give users an idea of the layout and colors, this is not a feature showcase like the press screenshots on the website.

= I'd rather keep the old previews than waiting for new polished ones.

(formally "requesting changes" so we don't merge the current state)

Copy link
Member

@ronso0 ronso0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@daschuer
Copy link
Member Author

OK, works for me. I have just issued the version bump PR. #14049

@daschuer daschuer modified the milestones: 2.5.0, 2.5.1 Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants