RateControl/Position ScratchController: use std::unique_ptr, PollingControlProxy etc. #14058
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swiftb0y
reviewed
Dec 26, 2024
src/engine/controls/ratecontrol.cpp
Outdated
Comment on lines
196
to
197
| m_pJog = std::make_unique<ControlObject>(ConfigKey(group, QStringLiteral("jog"))); | ||
| m_pJogFilter = std::make_unique<Rotary>(); |
There was a problem hiding this comment.
this is a refactoring, right? Should we rebase on main instead? I know I changed this line in main in #13853 so there are bound to be conflicts...
There was a problem hiding this comment.
this is a refactoring, right? Should we rebase on main instead?
Yes, and no: as metioned above, these are just preparational steps for the scratch fix #14059 which should go to 2.5 IMO
ronso0
force-pushed
the
ratecontrol-prep
branch
2 times, most recently
from
5112667 to
5b63d77
Compare
ronso0
force-pushed
the
ratecontrol-prep
branch
from
df3c7b8 to
9c033fa
Compare
Swiftb0y
reviewed
Dec 30, 2024
…ntrolProxy etc. Co-authored-by: Swiftb0y <[email protected]>
ronso0
force-pushed
the
ratecontrol-prep
branch
from
9c033fa to
65f0d9f
Compare
Swiftb0y
approved these changes
Dec 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some preparation for #14059
Targeting 2.5 because #14059 (or an alternative) may become an appropriate bug fix.