build: add missing deps for RPM systems #14183
Conversation
tools/rpm_buildenv.sh
Outdated
| @@ -26,6 +26,7 @@ case "$1" in | |||
| # builddep mixxx`). | |||
| sudo dnf install -y \ | |||
| appstream \ | |||
| boost-devel \ | |||
There was a problem hiding this comment.
What is our boost dependency on Fedora? I am not aware that boost is required on Debian based distros.
There was a problem hiding this comment.
Turns out it is actually needed on Debian-based system too, as patched in my Devcontainer PR
Boost is a dependency for qm-dsp, rigtorp and libdjinterop
There was a problem hiding this comment.
I never had to install it in the past, so I suspect Ubuntu-based OSes ship it by default?
There was a problem hiding this comment.
They don't depend on boost. Only the tests of libdjinterop do. But we don't deal with the tests. We use the prebuild binaries.
There was a problem hiding this comment.
Tried with a fresh box on main and can't reproduce so this might not be needed anymore
tools/rpm_buildenv.sh
Outdated
| @@ -26,6 +26,7 @@ case "$1" in | |||
| # builddep mixxx`). | |||
| sudo dnf install -y \ | |||
| appstream \ | |||
| boost-devel \ | |||
There was a problem hiding this comment.
They don't depend on boost. Only the tests of libdjinterop do. But we don't deal with the tests. We use the prebuild binaries.
Found couple of missing dependencies when installing on Fedora 41 using a Toolbox