Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use QModernWindowsStylePlugin for Qt >= 6.7 #14200

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Use QModernWindowsStylePlugin for Qt >= 6.7 #14200

merged 1 commit into from
Jan 20, 2025
+23 −4

Conversation

daschuer
Copy link
Member

No description provided.

@github-actions github-actions bot added the build label Jan 19, 2025
@daschuer daschuer mentioned this pull request Jan 19, 2025
Merged
@JoergAtGithub
Copy link
Member

I tried already myself, you need to alter

mixxx/CMakeLists.txt

Lines 3058 to 3060 in 10528b3

install(IMPORTED_RUNTIME_ARTIFACTS Qt${QT_VERSION_MAJOR}::QWindowsVistaStylePlugin
DESTINATION "${MIXXX_INSTALL_DATADIR}/styles"
COMPONENT applocal)
additional. Than it works, but style looks inconsistent in another way now.

@daschuer daschuer force-pushed the QModernWindowsStylePlugin branch from 10528b3 to 6bb75c5 Compare January 19, 2025 23:09
@daschuer
Copy link
Member Author

I have amended the first commit. Please check.

@daschuer daschuer force-pushed the QModernWindowsStylePlugin branch from 6bb75c5 to f275a20 Compare January 19, 2025 23:11
JoergAtGithub
JoergAtGithub approved these changes Jan 20, 2025
View reviewed changes
Copy link
Member

@JoergAtGithub JoergAtGithub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with the new buildenv! Please squash!

@daschuer daschuer force-pushed the QModernWindowsStylePlugin branch from 1c6580e to 032e22a Compare January 20, 2025 22:56
@daschuer
Copy link
Member Author

Done

@JoergAtGithub
Copy link
Member

Thank you!

@JoergAtGithub JoergAtGithub merged commit d406e93 into mixxxdj:2.5 Jan 20, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoergAtGithub JoergAtGithub JoergAtGithub approved these changes

Assignees
No one assigned
Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@daschuer @JoergAtGithub