Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix) menubar: don't show 'hide' dialog when switching skins #14254

Merged
merged 1 commit into from
Jan 28, 2025

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jan 28, 2025

don't show the dialog when switching skins while fullscreen.
furthermore, the hide dialog would block the preferences (wait cursor).

reported in #14094 (comment)

@ronso0 ronso0 added this to the 2.5.1 milestone Jan 28, 2025
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you.

@daschuer daschuer merged commit 23bbf79 into mixxxdj:2.5 Jan 28, 2025
13 checks passed
@ronso0 ronso0 deleted the menubar-fullscreen-skinswitch branch January 28, 2025 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants