DlgKeywheel: Make dialog a floating tool window #14256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Beside the different style I don't see a difference, Keywheel wass always on top for me (Linux, Qt 6.2.3), fullscreen or normal. |
|
Nope, wasn't the case before (just like none of of the other dialogs float, including things like preferences etc.). IIRC preferences don't float on Linux either, so that surprises me |
|
Hmmkay, for me all dialogs float, i.e. stay on top no matter which window I activate 🤷♂️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#14239 got me thinking whether we could make the keywheel a floating dialog to make it a bit more useful, given that the keywheel is usually needed e.g. while browsing tracks. This is essentially the same style that the effect GUI dialogs proposed in #13888 use.
I've also added the tool modifier which gives it a slightly thinner window bar, at least on macOS, where this nicely follows the convention laid out by the OS color picker: