Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(fix) DlgControllerLearning: make control box completer usable #14260

Merged
merged 2 commits into from
Jan 30, 2025
Merged

(fix) DlgControllerLearning: make control box completer usable #14260

merged 2 commits into from
Jan 30, 2025

Conversation

ronso0
Copy link
Member

@ronso0 ronso0 commented Jan 30, 2025

The implementation was complete but not very usable because some defaults were used.

  • use MatchContains (default is Qt::MatchStartsWith
  • set case-insensitive (default is Qt::CaseSensitive)

🎉

@ronso0 ronso0 mentioned this pull request Jan 30, 2025
Closed
@ronso0 ronso0 added this to the 2.5.1 milestone Jan 30, 2025
@ronso0 ronso0 linked an issue Jan 30, 2025 that may be closed by this pull request
Make MIDI Wizard text search fuzzy #14258
Closed
Swiftb0y
Swiftb0y approved these changes Jan 30, 2025
View reviewed changes
Copy link
Member

@Swiftb0y Swiftb0y left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

daschuer
daschuer reviewed Jan 30, 2025
View reviewed changes
Copy link
Member

@daschuer daschuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I can confirm the issue and the fix. Thank you.

@daschuer daschuer merged commit 9fb9fae into mixxxdj:2.5 Jan 30, 2025
13 checks passed
@ronso0 ronso0 deleted the midi-learn-completer-fix branch January 30, 2025 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Swiftb0y Swiftb0y Swiftb0y approved these changes

@daschuer daschuer daschuer approved these changes

Assignees
No one assigned
Labels
controllers preferences usability
Projects
None yet
Milestone
2.5.1
Development

Successfully merging this pull request may close these issues.

Make MIDI Wizard text search fuzzy
3 participants
@ronso0 @daschuer @Swiftb0y