Add Azure code signing for the Windows release DLLs #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
force-pushed
the
azure_codesign
branch
from
76bcc7d to
c7f84c6
Compare
daschuer
force-pushed
the
azure_codesign
branch
from
c7f84c6 to
68f4f14
Compare
|
This can be merged independent of this CI, because the PR has no access the the GitHub secret. |
JoergAtGithub
requested changes
Dec 26, 2023
| endpoint: https://weu.codesigning.azure.net/ | ||
| code-signing-account-name: mixxx | ||
| certificate-profile-name: mixxx | ||
| files-folder: ${{ matrix.vcpkg_path }}/installed/${{ matrix.vcpkg_triplet }}/bin |
There was a problem hiding this comment.
Suggested change
| files-folder: ${{ matrix.vcpkg_path }}/installed/${{ matrix.vcpkg_triplet }}/bin | |
| files-folder: ${{ matrix.vcpkg_path }}/installed/${{ matrix.vcpkg_triplet }}/ | |
| files-folder-recurse: true |
Otherwise, the Qt plugin DLLs remain unsigned
|
I don't think we need to sign .exe files, because we don't ship .exe binaries from VCPKG. But we need to sign the .dll files from the plugins directory as suggested above. |
daschuer
force-pushed
the
azure_codesign
branch
from
c9537d3 to
afc98d3
Compare
|
Oh, I have missed to adjust the root folder for signing. The exe files, I have added, because we can this way allow the contributors to verify the build tools as well. |
daschuer
force-pushed
the
azure_codesign
branch
from
afc98d3 to
b7f4c0f
Compare
|
Signing all recursive fails with Now trying to select the plugins folder explicit. |
|
Can you report it upstream - AFAIK Azure Code Signing is still in Beta and they need our feedback |
|
LGTM! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.