-
-
Notifications
You must be signed in to change notification settings - Fork 303
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support ES class properties #304
base: master
Are you sure you want to change the base?
Conversation
@@ -23,7 +23,8 @@ export default function rewriteBareModuleIdentifiers(code, packageConfig) { | |||
plugins: [ | |||
unpkgRewrite(origin, dependencies), | |||
'@babel/plugin-proposal-optional-chaining', | |||
'@babel/plugin-proposal-nullish-coalescing-operator' | |||
'@babel/plugin-proposal-nullish-coalescing-operator', | |||
'@babel/plugin-proposal-class-properties' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to add to https://github.com/mjackson/unpkg/blob/master/package.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
both of those are already included in package.json
@mjackson |
It's been two years since the last comment. With TS having landed proper ESM support more projects are likely going to make the move and more people will run into this issue. Can we get this fixed? |
I didn't wait, I went to a competitive product: |
Fixes #303