Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support ES class properties #304

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bennypowers
Copy link

Fixes #303

@@ -23,7 +23,8 @@ export default function rewriteBareModuleIdentifiers(code, packageConfig) {
plugins: [
unpkgRewrite(origin, dependencies),
'@babel/plugin-proposal-optional-chaining',
'@babel/plugin-proposal-nullish-coalescing-operator'
'@babel/plugin-proposal-nullish-coalescing-operator',
'@babel/plugin-proposal-class-properties'

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

both of those are already included in package.json

@bennypowers bennypowers changed the title Update rewriteBareModuleIdentifiers.js Support ES class properties Sep 29, 2021
@alangdm
Copy link

alangdm commented Apr 22, 2022

@mjackson
Is there any chance we could get this PR merged?
Static class fields have been supported in all modern browsers for a while now so it would be awesome to be able to use them through unpkg too 🙏

@pluma4345
Copy link

It's been two years since the last comment. With TS having landed proper ESM support more projects are likely going to make the move and more people will run into this issue. Can we get this fixed?

@IgorNovozhilov
Copy link

IgorNovozhilov commented Apr 18, 2024

@pluma4345 (#303 (comment))

It's been two years since the last comment. With TS having landed proper ESM support more projects are likely going to make the move and more people will run into this issue. Can we get this fixed?

I didn't wait, I went to a competitive product:
https://cdn.jsdelivr.net/npm/[email protected]/esm/database.js?+esm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for the experimental syntax 'classProperties' isn't currently enabled
4 participants