Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade mime for improved CJS handling #364

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

benmccann
Copy link

.cjs is being served as text/plain, which is incorrect. This PR upgrades the mime package as this is fixed in newer versions of it. See #355 (comment)

@matschik
Copy link

matschik commented Jul 4, 2023

Looking forward for this PR to be merged, I got the same mime type issue when importing a ".cjs" file.

Copy link

@mayank1513 mayank1513 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very important if it handles .cjs files properly. Please merge it ASAP.

@tennox
Copy link

tennox commented Dec 9, 2023

@mjackson shy bump 😅

@Swivelgames
Copy link

Swivelgames commented Jul 25, 2024

Fixes #355
Fixes #268

EDIT: I think this needs to go in the PR's description in order for it to track properly 😅

@beemdvp
Copy link

beemdvp commented Oct 20, 2024

Please merge, would be great 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants