fix: 🐛 auto appendChild works only for not defined remount

mjancarik · May 23, 2024 · a4a761a · a4a761a
1 parent 2471f91
commit a4a761a
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 7 deletions.
diff --git a/packages/create-widget/views/preact/template.json b/packages/create-widget/views/preact/template.json
@@ -1,6 +1,6 @@
 {
   "dependencies": {
-    "@merkur/preact": "0.35.0"
+    "@merkur/preact": "0.36.0"
   },
   "devDependencies": {
     "enzyme": "3.11.0",

diff --git a/packages/create-widget/views/svelte/template.json b/packages/create-widget/views/svelte/template.json
@@ -1,6 +1,6 @@
 {
   "dependencies": {
-    "@merkur/svelte": "0.35.0"
+    "@merkur/svelte": "0.36.0"
   },
   "devDependencies": {}
 }
diff --git a/packages/create-widget/views/uhtml/template.json b/packages/create-widget/views/uhtml/template.json
@@ -1,6 +1,6 @@
 {
   "dependencies": {
-    "@merkur/uhtml": "0.35.0"
+    "@merkur/uhtml": "0.36.0"
   },
   "devDependencies": {}
 }
diff --git a/packages/integration-custom-element/src/index.js b/packages/integration-custom-element/src/index.js
@@ -59,10 +59,16 @@ function registerCustomElement(options) {
               customElement: this,
             });
 
-            (await callbacks?.remount?.(this._widget, {
-              shadow: this._shadow,
-              customElement: this,
-            })) ?? this._shadow.appendChild(widget.container);
+            if (typeof callbacks?.remount === 'function') {
+              await callbacks?.remount?.(this._widget, {
+                shadow: this._shadow,
+                customElement: this,
+              });
+            } else {
+              widget.root = this._shadow;
+              widget.customElement = this;
+              this._shadow.appendChild(widget.container);
+            }
 
             return;
           }