Skip to content

Commit

Permalink
[COOP report] Add support for report-only
Browse files Browse the repository at this point in the history
This adds the support for report-only COOP triggered Browsing context
group switches.
During navigation, besides computing whether COOP triggers a BCG switch,
this also computes if any of the report-only policies would also trigger
a switch if they were effective, the resulting values are stored in
booleans within |CrossOriginOpenerPolicyStatus|.
This booleans are then used to trigger the navigation reports, and in a
follow up to trigger access reports.

Explainer [WIP]:
https://github.com/camillelamy/explainers/blob/master/coop_reporting.md

Specification [WIP]:
whatwg/html#5518

Bug: 1099208
Change-Id: I2cb66ec5cdcd9d5b4658c28f0608bc6b52d0da6b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241529
Commit-Queue: Pâris Meuleman <[email protected]>
Reviewed-by: Camille Lamy <[email protected]>
Reviewed-by: Arthur Hemery <[email protected]>
Auto-Submit: Pâris Meuleman <[email protected]>
Cr-Original-Commit-Position: refs/heads/master@{#790781}
Cr-Mirrored-From: https://chromium.googlesource.com/chromium/src
Cr-Mirrored-Commit: 9c2ef27118d4009c5fa8659a04b74b48aa0ca574
  • Loading branch information
ParisMeuleman authored and Commit Bot committed Jul 22, 2020
1 parent fd1a53c commit 2d94672
Show file tree
Hide file tree
Showing 6 changed files with 3 additions and 28 deletions.
2 changes: 0 additions & 2 deletions blink/web_tests/TestExpectations
Original file line number Diff line number Diff line change
Expand Up @@ -2895,8 +2895,6 @@ crbug.com/626703 [ Linux ] external/wpt/mathml/presentation-markup/operators/mo-
crbug.com/626703 [ Mac ] external/wpt/mathml/presentation-markup/operators/mo-lspace-rspace-dynamic.html [ Failure ]
crbug.com/626703 [ Win ] external/wpt/mathml/presentation-markup/operators/mo-lspace-rspace-dynamic.html [ Failure ]
crbug.com/626703 [ Retina ] external/wpt/html/cross-origin-opener-policy/popup-coop-by-sw-from-coop.https.html [ Timeout ]
crbug.com/1099208 external/wpt/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-popup-same-origin.https.html [ Crash ]
crbug.com/1099208 external/wpt/html/cross-origin-opener-policy/reporting/navigation-reporting/reporting-popup-same-origin-coep-report-to.https.html [ Crash ]
crbug.com/626703 [ Mac10.14 ] external/wpt/webrtc/RTCRtpSender-replaceTrack.https.html [ Timeout ]
crbug.com/626703 [ Win ] external/wpt/webrtc/RTCRtpSender-replaceTrack.https.html [ Timeout ]
crbug.com/626703 [ Mac10.14 ] external/wpt/preload/onload-event.html [ Timeout ]
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
SAME_ORIGIN,
"",
"",
`same-origin; report-to="${popupReportEndpoint.name}"`,
`same-origin; report-to="${popupReportOnlyEndpoint.name}"`,
"require-corp",
[
{
Expand All @@ -127,7 +127,8 @@
"url": `${location.href}`,
"type": "coop"
}
},]
}
]
],
// Open a cross-origin popup with a same-origin COOP report only. A report is
// sent to both this page's endpoint and the popup's.
Expand Down

0 comments on commit 2d94672

Please sign in to comment.