Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi.
I would like to propose three small modifications, in order to address the issue #60.
The major change is that now, the normalize() function basically uses the sum of each row of values in data, instead of the
max_dat
. This protects the case wheremax_dat < width
against bad bar plots.I also changed int() to round() to make sure that the bars (almost) add up to 100 when the data is expressed in percentage. Otherwise, the bars would not line up nicely.
Please let me know what you think of the changes.
Kind regards
Ehsan