Fix build when htole64 and related macros are defined in endian.h or sys/endian.h #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, if htole64 is available on a platform as a macro in endian.h or sys/endian.h the AC_CHECK_DECL check does not detect them as these files are not included in the test. As those two headers are however included in the build this causes the declarations of the compat functions to be mangled by the undetected macros and fail to compile. Resolve this by passing conditional includes of endian.h and sys/endian.h to the includes parameter of the AC_CHECK_DECL macro so that the htole64 macro is detected correctly.
ribbons
added a commit
to ribbons/android-dropbear
that referenced
this pull request
Mar 7, 2025
Add a patch (submitted upstream as mkj/dropbear#352) which fixes the detection of htole64 and related macros by configure and so resolves the resulting build failure.
ribbons
added a commit
to ribbons/android-dropbear
that referenced
this pull request
Mar 7, 2025
Add a patch (submitted upstream as mkj/dropbear#352) which fixes the detection of htole64 and related macros by configure and so resolves the resulting build failure.
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if
htole64is available on a platform as a macro inendian.horsys/endian.htheAC_CHECK_DECLtest does not detect them as they are not included in it. As those two headers are however included in the build this causes the declarations of the compat functions to be mangled by the undetected macros and fail to compile.Resolve this by passing conditional includes of
endian.handsys/endian.hto the includes parameter of theAC_CHECK_DECLmacro so that thehtole64macro is detected correctly.(I found this when attempting to cross compile 2025.87 for Android where
htole64is a macro defined insys/endian.h.)