Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update mx.random.normal calls #643

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

LeonEricsson
Copy link
Contributor

@LeonEricsson LeonEricsson commented Feb 6, 2024

Proposed changes

updated existing mx.random.normal to make use of #638

Checklist

Put an x in the boxes that apply.

  • I have read the CONTRIBUTING document
  • I have run pre-commit run --all-files to format my code / installed pre-commit prior to committing changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have updated the necessary documentation (if needed)

Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@awni
Copy link
Member

awni commented Feb 7, 2024

Any reason to keep this a draft?

@LeonEricsson LeonEricsson marked this pull request as ready for review February 7, 2024 21:16
@LeonEricsson
Copy link
Contributor Author

Any reason to keep this a draft?

was waiting to see if #638 changed. do you mind taking a look at the prompt lookup pr when you've got some time over, its ready for merge

Copy link
Member

@awni awni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@awni awni merged commit 7dccd42 into ml-explore:main Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants