Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #272 #273

Merged
merged 2 commits into from
May 7, 2024
Merged

fix #272 #273

merged 2 commits into from
May 7, 2024

Conversation

ksthicke
Copy link
Contributor

@ksthicke ksthicke commented May 5, 2024

Purpose

Fixes #272 by fixing two things in cpForWhiteStr:

  1. Makes sure pgnBoard is set correctly. Previously, it was setting it to the current board when there was no FEN header and setting it to the starting board when there was a FEN header. Now, it always sets it to the starting FEN.
  2. Fixes another issue where the result of the game was incorrectly shown. In particular, the code was designed to be correct for standard chess, but was not correct for Horde. It should now be correct for any variant since it is calling the methods of state.board.

Pre-merge TODOs and Checks

  • (exclude checks that are not relevant for your feature)
  • PGN file loads correctly
  • Navigating through the move history works
  • Starting the engine shows moves (test for both sides)
  • Selecting a different variant loads a new board with the variant and you can make moves on the board
  • In Crazyhouse the pocket pieces are shown and you can drop pieces

ksthicke and others added 2 commits May 2, 2024 21:07
@QueensGambit
Copy link
Collaborator

Thank you for fixing this issue @ksthicke .
I changed pgnBoard to const according to the lint checker.

@QueensGambit QueensGambit merged commit 3cc602b into ml-research:master May 7, 2024
1 check passed
@ksthicke ksthicke deleted the hordefix branch May 12, 2024 01:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Analysis breaks during Horde
2 participants