Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with dragging pieces in Crazyhouse #274

Merged
merged 2 commits into from
May 14, 2024

Conversation

ksthicke
Copy link
Contributor

Purpose

Fixes #254 by preventing default when starting to drag. Don't ask me why this fixed it -- I have no idea.

I also removed a couple relevant console.log statements that were polluting the console.

Pre-merge TODOs and Checks

  • PGN file loads correctly
  • Navigating through the move history works
  • Starting the engine shows moves (test for both sides)
  • Selecting a different variant loads a new board with the variant and you can make moves on the board
  • In Crazyhouse the pocket pieces are shown and you can drop pieces

@QueensGambit QueensGambit merged commit a835dc8 into ml-research:master May 14, 2024
1 check passed
@QueensGambit
Copy link
Collaborator

Great. Thanks a lot for fixing this issue!

@ksthicke ksthicke deleted the droppingpiece branch May 19, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crazyhouse dropping pieces issue
2 participants