Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fixes #276

Merged
merged 5 commits into from
May 22, 2024
Merged

Bug fixes #276

merged 5 commits into from
May 22, 2024

Conversation

ksthicke
Copy link
Contributor

Purpose

Fixes a couple bugs.

  1. Makes the arrow keys work when the checkbox is in focus.
  2. (not a bug) Removes unused code.
  3. Upgrades ffish, which fixes Support 3check pasting of other FEN variants #185

Pre-merge TODOs and Checks

  • PGN file loads correctly
  • Navigating through the move history works
  • Starting the engine shows moves (test for both sides)
  • Selecting a different variant loads a new board with the variant and you can make moves on the board
  • In Crazyhouse the pocket pieces are shown and you can drop pieces

@ksthicke
Copy link
Contributor Author

It looks like it didn't pass the check because I've always been having to use --legacy-peer-deps in order to get it to build. I'm probably just doing something stupid, but using npm and dealing with dependencies is very new to me.

@QueensGambit
Copy link
Collaborator

Thanks for the updates. I see, should we remove package-lock.json in this case to fix the lint issue?

@ksthicke
Copy link
Contributor Author

Whatever you did with package-lock.json seems to have worked -- thanks!

@QueensGambit
Copy link
Collaborator

Great, that it works now.
I set ffish": "^0.7.6 and run npm install locally.
Next, I uploaded the resulting package-lock.json file.

@QueensGambit QueensGambit merged commit e20dc0d into ml-research:master May 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support 3check pasting of other FEN variants
2 participants