-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixing strange parses #117
Conversation
29d7d4d
to
f2fb0fd
Compare
lambda-buffers-frontend/test/Test/LambdaBuffers/Frontend/Parsec.hs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaredponn thank you so much! this is incredible work and I learned a lot.
This is pure gold.
The only thing I want you to do is to extract that big comment about the syntax and put it in a chapter.
lambda-buffers-frontend/test/Test/LambdaBuffers/Frontend/Parsec.hs
Outdated
Show resolved
Hide resolved
d45b655
to
f7c4519
Compare
Thank you @bladyjoker for the feedback, it's very appreciated. As requested, I wrote a quick chapter over here. |
f7c4519
to
e697b61
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very lovely documentation! Left some comments for you to attend to, but feel free to merge this at your leisure. We will definitely iterate on this chapter some more so no need to get it perfect the first time around.
- Uniform handling of whitespace - Added a syntactic specification in the comments - Updated test suite to reflect the changes
- Changed parsing test case to no longer use keywords as a field name (as per the specification) - Improved `LambdaBuffers/Frontend/Parsec.hs` documentation - Updated TODO in `Test/LambdaBuffers/Frontend/Parsec.hs` - Fixed `LambdaBuffers/Frontend/Parsec.hs` incorrectly parsing `:--`
- Fixed strange whitespace (added whitespace after headers / put paragraphs in a single line) - Changed `long` to `modulealias` - General wording improvements + fixed error in `opaque` type defn.
05f0e44
to
72086d2
Compare
In light of issue #116, this fixes some of the strange somewhat nonintuitive parses.
High level overview of changes